Added Phys File Type, Added more M2 chunks (some unfinished), changed some smaller things #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Luzifix
requested changes
Aug 13, 2024
Luzifix
reviewed
Sep 6, 2024
| @@ -0,0 +1,54 @@ | |||
| using System; | |||
There was a problem hiding this comment.
Remove Mat3x4 because we now have a Matrix3x4 class
Luzifix
reviewed
Sep 6, 2024
| { | ||
| public enum BodyType : ushort | ||
| { | ||
| root = 0, |
There was a problem hiding this comment.
All keys in a Enum need to be started with a upper letter
Luzifix
reviewed
Sep 6, 2024
| { | ||
| public enum JointType : ushort | ||
| { | ||
| sphericalJoint = 0, |
There was a problem hiding this comment.
All keys in a Enum need to be started with a upper letter
Luzifix
reviewed
Sep 6, 2024
| { | ||
| public enum ShapeType : short | ||
| { | ||
| box = 0, |
There was a problem hiding this comment.
All keys in a Enum need to be started with a upper letter
Luzifix
reviewed
Sep 6, 2024
| bw.Write((uint)PLYTEntries.Count); | ||
| foreach (PLYTEntry obj in PLYTEntries) | ||
| { | ||
| Console.WriteLine("Writing Plyt Header Length: " + obj.SerializeHeader().Length); |
There was a problem hiding this comment.
Remove Console.WriteLine the lib dont write anything into the console
Luzifix
reviewed
Sep 6, 2024
| /// <summary> | ||
| /// Holds the binary chunk signature. | ||
| /// </summary> | ||
| public const string Signature = "EXP2"; |
Luzifix
reviewed
Sep 6, 2024
Warcraft.NET/Files/SKIN/Skin.cs
Outdated
| /// </summary> | ||
| public byte[] Unk0; | ||
|
|
||
| public bool Wotlk = false; |
There was a problem hiding this comment.
Implement versioning via one file per version and inheritance, maybe check how WDL is versioned.
Luzifix
requested changes
Sep 6, 2024
There was a problem hiding this comment.
Good Work there are only some small things are missing
- https://github.com/ModernWoWTools/Warcraft.NET/pull/11/files#r1713338913
- https://github.com/ModernWoWTools/Warcraft.NET/pull/11/files#r1713350960
- https://github.com/ModernWoWTools/Warcraft.NET/pull/11/files#r1713371341
- https://github.com/ModernWoWTools/Warcraft.NET/pull/11/files#r1713382194
- https://github.com/ModernWoWTools/Warcraft.NET/pull/11/files#r1713382463
- https://github.com/ModernWoWTools/Warcraft.NET/pull/11/files#r1713384484
- https://github.com/ModernWoWTools/Warcraft.NET/pull/11/files#r1714349384
- https://github.com/ModernWoWTools/Warcraft.NET/pull/11/files#r1714351333
- https://github.com/ModernWoWTools/Warcraft.NET/pull/11/files#r1714353567
- https://github.com/ModernWoWTools/Warcraft.NET/pull/11/files#r1714354357
- https://github.com/ModernWoWTools/Warcraft.NET/pull/11/files#r1746858870
- https://github.com/ModernWoWTools/Warcraft.NET/pull/11/files#r1746871143
- https://github.com/ModernWoWTools/Warcraft.NET/pull/11/files#r1746871299
- https://github.com/ModernWoWTools/Warcraft.NET/pull/11/files#r1746871399
- https://github.com/ModernWoWTools/Warcraft.NET/pull/11/files#r1746889874
- https://github.com/ModernWoWTools/Warcraft.NET/pull/11/files#r1746897251
- https://github.com/ModernWoWTools/Warcraft.NET/pull/11/files#r1746907965
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.